kingjaypee12/MKM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(client): extract base account generation to command

Browse Source 
Move the logic for generating base accounts for a new client from the ClientObserver into a dedicated command class (GenerateBaseAccountCommand). This improves code organization and reusability.

- The command is now used in the ClientObserver::created method.
- The command is also made available as a manual action in the AccountsRelationManager table header, allowing admins to generate base accounts for existing clients that lack them.
- Added necessary imports to the CreateSale page, though the command is not directly used there in this diff, suggesting preparatory work for future integration.
This commit is contained in:
Jp
2026-02-16 02:02:26 +08:00
parent 7bcfaff311
commit 8c6fa6cb08
4 changed files with 84 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
app/Observers/ClientObserver.php
View File

@@ -2,6 +2,7 @@
namespace App\Observers;
use App\Commands\Clients\GenerateBaseAccountCommand;
use App\Models\Client;
use Illuminate\Support\Facades\DB;
@@ -12,45 +13,7 @@ class ClientObserver
*/
public function created(Client $client): void
{
DB::transaction(function () use ($client) {
$client->accounts()->createMany([
[
'account_type_id' => 1,
'account' => 'Cash',
'normal_balance' => 'debit',
],
[
'account_type_id' => 1,
'account' => 'Input Tax',
'normal_balance' => 'debit',
],
[
'account_type_id' => 1,
'account' => 'Creditable Withholding Tax',
'normal_balance' => 'debit',
],
[
'account_type_id' => 2,
'account' => 'Output Tax',
'normal_balance' => 'credit',
],
[
'account_type_id' => 2,
'account' => 'Payable Withholding Tax',
'normal_balance' => 'credit',
],
[
'account_type_id' => 5,
'account' => 'Vat Exempt Revenue',
'normal_balance' => 'credit',
],
[
'account_type_id' => 4,
'account' => 'Sales Discount',
'normal_balance' => 'debit',
],
]);
});
app(GenerateBaseAccountCommand::class)->execute($client);
}
/**